From b3098fe68a0559b8a8958f2ec1a537d7468ad72c Mon Sep 17 00:00:00 2001 From: "Satadru Pramanik, DO, MPH, MEng" Date: Wed, 3 Sep 2025 11:23:23 -0400 Subject: [PATCH] acme-common: cleanup acme start crontab migration The '/etc/init.d/acme start' crontab migration should also delete the existing '/etc/init.d/acme start' line. Otherwise, on every sysupgrade that carries forward existing configurations, a new '0 0 * * * /etc/init.d/acme renew' line is added to the crontab. Furthermore, do not add an 'acme renew' crontab line if it already exists. Signed-off-by: Satadru Pramanik, DO, MPH, MEng --- net/acme-common/Makefile | 2 +- net/acme-common/files/acme.uci-defaults | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/acme-common/Makefile b/net/acme-common/Makefile index e05b943c9a..f8f4898143 100644 --- a/net/acme-common/Makefile +++ b/net/acme-common/Makefile @@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=acme-common -PKG_VERSION:=1.4.3 +PKG_VERSION:=1.4.4 PKG_MAINTAINER:=Toke Høiland-Jørgensen PKG_LICENSE:=GPL-3.0-only diff --git a/net/acme-common/files/acme.uci-defaults b/net/acme-common/files/acme.uci-defaults index bf1bcb10fa..326f1e8c14 100644 --- a/net/acme-common/files/acme.uci-defaults +++ b/net/acme-common/files/acme.uci-defaults @@ -55,7 +55,8 @@ uci_commit # Migrate '/etc/init.d/acme start' to '/etc/init.d/acme renew' grep -q '/etc/init.d/acme start' /etc/crontabs/root 2>/dev/null && { - echo "0 0 * * * /etc/init.d/acme renew" >>/etc/crontabs/root + grep -q '/etc/init.d/acme' /etc/crontabs/root 2>/dev/null || echo "0 0 * * * /etc/init.d/acme renew" >>/etc/crontabs/root + sed '/0 0 * * * \/etc\/init.d\/acme start/d' /etc/crontabs/root } exit 0 -- 2.30.2